Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drupal 9 compatibility #156

Merged
merged 26 commits into from
Jun 26, 2020
Merged

Drupal 9 compatibility #156

merged 26 commits into from
Jun 26, 2020

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Jun 3, 2020 •
edited
Loading

Testing

Follow the instructions on palantirnet/drupal-skeleton#111 to setup a new example project using this branch of the-build.

Note: After review and testing is complete, change the CircleCI config to use the develop branch of the Drupal Skeleton. See

the-build/.circleci/config.yml

Line 76 in 744c327

command: composer create-project palantirnet/drupal-skeleton example dev-drupal9 --no-interaction

@byrond byrond self-assigned this Jun 3, 2020
@byrond byrond changed the title use version 3 of Devel, which supports D9 Drupal 9 compatibility Jun 3, 2020
byrond added 17 commits June 3, 2020 17:13
@byrond
update deprecated function call in the_build_utility.install
0c8dc7f
@byrond
add shortcut as a dependency
7ea0cf3
@byrond
switch to minimal profile for first install
b6d73c9
@byrond
remove the old line 🤦
fba8470
@byrond
use field_storage_config in the_build_utility.install
ea9b44b
@byrond
change first install profile to "newstandard" (sans hook_install)
095860e
@byrond
remove core module dependency
83d2921
@byrond
use existing-config option instead of config_installer
dce4e34
@byrond
fix user registration setting value during the_build_utility install
62eecfd
@byrond
add hook_install from standard profile
2a891c3
@byrond
update config for minimal profile after first install
d08d751
@byrond
switch back to standard profile for first install
f93618b
@byrond
update change log from #147
de85860
@byrond
add deprecation comment to defaults.yml
17e3159 
See #147
@byrond
update shortcut weights
48c6177
@byrond
update post first installation message
2b3d081 
see #147
@byrond
update default build.xml to enable/uninstall the_build_utility during…
9800a92 
… phing install
@byrond byrond requested a review from becw June 5, 2020 15:46
@byrond
Copy link
Contributor Author

byrond commented Jun 5, 2020

CircleCI is failing during installation, because it can't find the kint module. I have not seen this problem locally.

@byrond
Copy link
Contributor Author

byrond commented Jun 5, 2020

I need to fix this. Maybe re-installing the_build_utility wasn't so bright.

In PreExistingConfigException.php line 65:
                                                                               
  Configuration objects (config_split.config_split.development, config_split.  
  config_split.production, config_split.config_split.staging) provided by the  
  _build_utility already exist in active configuration

@becw
Copy link
Member

becw commented Jun 5, 2020

I just tried this for the first time, and when I run vendor/bin/the-build-installer and select acquia I get:

[phingcall] /Users/white/repos/drupal-skeleton/vendor/palantirnet/the-build/targets/install.xml:251:176: Could not find file /Users/white/repos/drupal-skeleton/docroot/sites/default/default.services.yml to copy.

However, I think I got this before as well, so it's likely not an issue with this PR.

@becw
Copy link
Member

becw commented Jun 5, 2020

Ok, this is quite magical! and working!

I will review more closely on Monday. I'm wondering if we should release cut matching major versions of the-build and drupal-skeleton for this.

@byrond
Copy link
Contributor Author

byrond commented Jun 8, 2020

I just tried this for the first time, and when I run vendor/bin/the-build-installer and select acquia I get:

[phingcall] /Users/white/repos/drupal-skeleton/vendor/palantirnet/the-build/targets/install.xml:251:176: Could not find file /Users/white/repos/drupal-skeleton/docroot/sites/default/default.services.yml to copy.

However, I think I got this before as well, so it's likely not an issue with this PR.

Oh, interesting. I wonder if that's due to the scaffolding. I'll look into that separately.

becw added 3 commits June 8, 2020 18:18
@becw
Break the change profile functionality out into a separate phing comm…
cadf292 
…and so that it can be used when removing the dependency on config_installer.
@becw
Merge pull request #158 from palantirnet/change-profile
afe2516 
Break the change profile functionality out into a separate phing comm…
@becw
Merge branch 'develop' into drupal9
da6405c
@becw becw merged commit 41f2385 into develop Jun 26, 2020
@becw becw deleted the drupal9 branch June 26, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becw becw Awaiting requested review from becw

Assignees

@byrond byrond

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byrond @becw